Conversation
hannessolo
approved these changes
Mar 2, 2026
| } | ||
| } | ||
| document.body.addEventListener('aue:content-patch', ({ detail: { patch, request } }) => { | ||
| if (!/image/.test(patch.name)) return; |
Collaborator
There was a problem hiding this comment.
didn't we say that we move this to check of the data-aue-type as it is done in the cors.js?
What if someone is silly naming any text input field image?
Author
There was a problem hiding this comment.
Ok, wanted to keep it simpler :-)
Actually we can remove that line and it should still work. A we check for media type 3 lines below.
| if (element?.getAttribute('data-aue-type') !== 'media') return; | ||
|
|
||
| (element.tagName === 'IMG' ? element.closest('picture') : element) | ||
| ?.querySelectorAll('source') |
Collaborator
There was a problem hiding this comment.
could we just search for all elements having srcset attribute set (so it would also include img tags) and remove them?
Author
There was a problem hiding this comment.
But source tags we would have to remove, while img srcset would would only need to remove the attribute. Will create a new PR for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See adobe/da-universal#173