[CLIENT-3994] Improve error actionability by adding subcode field to AerospikeError#1103
Draft
juliannguyen4 wants to merge 40 commits into
Draft
Conversation
…-3994-improve-error-actionability
…-3994-improve-error-actionability
…xpressions' into CLIENT-3994-improve-error-actionability
…xpressions' into CLIENT-3994-improve-error-actionability
…eck for verbosity levels > 2, so I guess the server will return an error.
…tuple of exception args.
…ed server versions. This is to make sure undefined behavior doesn't happen in the client (e.g uninitialized reads)
… the server now has the correct 8.1.3 version.
…-3994-improve-error-actionability
…xpressions' into CLIENT-3994-improve-error-actionability
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## CLIENT-4836-add-string-ops-and-expressions #1103 +/- ##
==============================================================================
- Coverage 84.98% 84.96% -0.02%
==============================================================================
Files 102 102
Lines 14836 14857 +21
==============================================================================
+ Hits 12608 12623 +15
- Misses 2228 2234 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…) and append() only when strings are passed as arguments in favor of the string ops version.
…prepend() and append() only when strings are passed as arguments in favor of the string ops version." This reverts commit ae388db.
…eaking change per product team's request.
… op API." This reverts commit d8ec58b.
…xpressions' into CLIENT-3994-improve-error-actionability
…xpressions' into CLIENT-3994-improve-error-actionability
…-3994-improve-error-actionability
juliannguyen4
changed the title
…-3994-improve-error-actionability
…s at index tuple_size
… as integers to be consistent with the as_connection fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not adding new subcode attribute to
AerospikeError.argstuple to avoid a breaking API change.TODO
Doc changes