ci: publish release bundles under direct VERSION (uniform across tools)#120
Merged
Conversation
Removes the branch-prefixed BUNDLE_VERSION so non-release / feature-branch publishes no longer double the branch name (e.g. master-4.5.6-master.<sha>). All publishes now use the SemVer VERSION directly, matching aerospike-admin: real release -> X.Y.Z; non-release/feature -> X.Y.Z-<branch>.<sha>.
a-spiker
force-pushed
the
tools/release-bundle-direct-version
branch
from
f62f53c to
090b97c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 15 15
Lines 2101 2101
=======================================
Hits 1703 1703
Misses 296 296
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the branch-prefixed
BUNDLE_VERSIONand publish every JFrog release bundle under the SemVerVERSIONdirectly, matchingaerospike-admin(asadm). This makes the release-bundle version scheme uniform across all five tools.Why
Non-release / feature-branch publishes were doubling the branch name, e.g.
main-0.21.1-main.<sha>, becauseVERSIONalready embeds<branch>.<sha>as a SemVer pre-release tag andBUNDLE_VERSIONprepended<branch>-again. The SHA already disambiguates, so the prefix was redundant.Resulting version pattern (now identical for all 5 tools)
0.21.10.21.1-main.<sha>(branch appears once)Note
This branch also carries earlier related CI commit(s) that were already on it. Draft for review.