jay: Add at v1.14.0 - #2211
jay: Add at v1.14.0#2211witchlliee wants to merge 2 commits into
Conversation
c5562a6 to
7d3953a
Compare
|
This looks neat! However we now need a package addition request prior to making a PR for it. For now I'll make this a draft if you will put in an addition request for it. |
|
Do I need to also open a issue requesting the package? What is the difference tho? |
|
Yes. We'll need to approve a package request before a PR is put in. |
Hey Ellie, We had noticed lately that we had been getting more and more PRs where there hadn't been any prior engagement with the team as to the contributors intention to submit the PR before it landed. There were cases where the team can't currently accept the PR (for any given number of reasons) and so it was adding up to lost time for all parties involved. As the project grows, we do need to add a little formality into the process so everyone is clear on where they stand and what's expected of them. You're catching us right in the middle of this process where we are fine-tuning everything. For new packages, the process flow will be:
I need to continue refining our documentation across the board in line with this latest position, so I don't begrudge that you submitted a new package PR as the guidance wasn't yet clear. I can see that you've already submitted the request so I appreciate you for engaging with the process! |
|
Ah sorry. I thought just making the PR was enough. Will remember this for future packages I may want to PR. |
|
@witchlliee Hey, I also had a package on my side for jay but I don't have the same build deps. Are you interested in discussing them ? I found that building with only builddeps :
- pkgconfig(cairo)
- pkgconfig(gbm)
- pkgconfig(libinput)
- pkgconfig(pango)seems enough |
|
Ah, I think I got some dependencies wrong anyway which led to some problems in my testing. Will check it soon. Here is the dependencies which the package needs: |
|
Will reopen this again since package request was approved. Thank you <3 |
d7b3262 to
2b88275
Compare
I know about this page, I started to create my stone a while ago and I went with a whack a mole approach to add only needed dependency to build jay, and to run, I guess my AerynOS with desktop mode (and sway on the side) was enough to run it. You can find my package here. For the rundeps, I think gnome-keyring would not be needed, maybe as a desktop package built around jay. I wonder how moss could support optionnal deps, for exemple pipewire for screen recording, or sqlite libs to have session restore, or opengl renderer. What do you think? |
gnome-keyring is needed in order for some applications to work properly. Niri also includes it, so I thought it wouldn't hurt including it here as well. And moss still doesn't handle optional deps |
I think this is to provide a backend for the secret xdg portal, but currently you can choose between kdewallet or gnome-keyring, and if someone is to build a desktop with more kde apps than gnome, the kdewallet would be the obvious choice (I like kde looks more than gnome's ^^') Maybe standalone compositors should come barebones, and let the user setup the component while we miss optional dependencies, or abstract one (we could imagine that jay requires a xdg-desktop-portal-secret-backend that would be provided by kdewallet, gnome-keyring or whatever someone could come up with). When I look at sway's stone, it comes with a few dependencies including the terminal emulator of the default config. Maybe we could simply check what is in jay's default config and only add this as runtime dependencies for now. |
|
I've had to research this a bit. I think we should drop EDIT: Oh. And |
I don't think we should include any that. Other WMs here also don't do that. This can added for a pkgset for Jay later on. I will probably work on it myself if approved. About |
|
Actually, alacritty at least is a good idea. Still, I feel bad adding programs, since there is no way they can remove it afterwards if they prefer another program |
|
I keep my stance about not adding |
|
I think we need to keep in the spirit of the upstream as far as what they require. I think adding sqlite is appropriate as well. But since |
|
For now, this would be enough I think. Maybe this could be revised in the future when AerynOS comes production ready. |
Shouldn't we expect the people to install the programs they already use together with jay (terminal, launcher, or even shell)? Pipewire is already the default on AerynOS as well |
|
Not even their AUR package installs all of this: |
|
@witchlliee you're giving me a headache. 🙃 As I said before, let's include what's expected upstream, |
Okey dokey. Bemenu is being a pain in the ass to package, the recipe is simple but when I install it to test, it doesn't launch unless I force the wayland backend with recipe: |
a stateless patch to read |
Okay, I have no idea how to patch that. From what I can see from their code, it should be searching for a renderer in that path. |
build : |
%make clients wayland PREFIX=%(prefix)
install : |
%make_install PREFIX=%(prefix)prefix defaults to /usr/local, at build time so need to add that during build as well |
This worked. Thanks!!! |
|
This should be ready now. Sorry for being a bit stubborn. I just want the best for the end user |
|
We all understand. Give me a day to look over this and audit it. |
| - pkgconfig(pango) | ||
| rundeps : | ||
| - binary(Xwayland) | ||
| - binary(gnome-keyring) |
There was a problem hiding this comment.
Jay’s session is just Exec=jay run and does not start a secrets daemon. niri pulls gnome-keyring because niri-session actually uses it. That does not apply here. Drop binary(gnome-keyring)
aerynOS New Package Pull Request
Summary
Another lightweight but powerful wayland compositor written in Rust. I really think this one deserves a spot.
Testing Performed
just buildcompletes successfully, the package installs viamossand that the application functions as expectedAdditional testing notes:
Nothing. Just build, install and log in into it.
Checklist
If you did NOT link to an approved issue, please explain why in the Additional Context section below.
Additional Context
There is no really package request for this one. It's not "very known" which is weird because it's really feature-rich. It has HDR, low-latency input, among other things for gaming.
https://mahkoh.github.io/jay/book/features.html
Screenshots / Output (if applicable)
Jay with noctalia: