Skip to content

firewalld: Add at v2.5.1 - #2368

Open
witchlliee wants to merge 2 commits into
aerynOS:mainfrom
witchlliee:add-firewalld
Open

witchlliee wants to merge 2 commits into
aerynOS:mainfrom
witchlliee:add-firewalld

Conversation

@witchlliee

@witchlliee witchlliee commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

aerynOS New Package Pull Request

Summary

Testing Performed

  • I have tested the package and can confirm that just build completes successfully, the package installs via moss and that the application functions as expected
  • No obvious security or stability concerns or any regressions observed in testing
  • The package was tested against the volatile stream

Additional testing notes:

Still won't build for some silly reason I can't understand #2357

Checklist

  • An approved package request issue exists (fixes: [Package Request]: firewalld #2367)
  • I have read and conformed to both the Package Addition Policy, and the Contributing Guidelines. I also confirm that this is my own work or properly attributed
  • No sensitive credentials, API keys, or secrets are included in this PR
  • I am willing to act as the primary maintainer for this package (optional but recommended)
  • This change could gainfully be highlighted in the Stream Update notes once merged

If you did NOT link to an approved issue, please explain why in the Additional Context section below.

Additional Context

I see we still don't have any firewall, so I think it's a important inclusion for better security.

Screenshots / Output (if applicable)

@witchlliee
witchlliee requested a review from a team as a code owner August 21, 2026 21:50
@witchlliee
witchlliee marked this pull request as draft August 21, 2026 21:51

@Jaredy899 Jaredy899 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This took me a while to figure out... You owe me :)

Let me know if anything is confusing.

Oh and we'll need a separate commit for systemd-preset-aeryn, to enable firewalld

Comment thread f/firewalld/pkg/fix_gettext_macros_path.patch
Comment thread f/firewalld/pkg/stateless.patch
Comment thread f/firewalld/stone.yaml
Comment thread f/firewalld/stone.yaml
Comment thread f/firewalld/stone.yaml
Comment thread f/firewalld/stone.yaml Outdated
Comment thread f/firewalld/stone.yaml Outdated
Comment thread f/firewalld/stone.yaml Outdated
@witchlliee

Copy link
Copy Markdown
Contributor Author

@Jaredy899

So I did all the changes and it's working fine, even firewalld-config but firewalld-applet refuses to work:

firewall-applet
Traceback (most recent call last):
  File "/usr/bin/firewall-applet", line 13, in <module>
    from dbus.mainloop.pyqt6 import DBusQtMainLoop
ModuleNotFoundError: No module named 'dbus.mainloop.pyqt6'

I have python-pyqt6 installed and also set it as rundep for firewalld-applet but it doesn't seem to do any effect

@Jaredy899

Copy link
Copy Markdown
Contributor

There's a comment in pyqt6 about not knowing if we want to enable dbus mainloop support. Maybe try rebuilding that package locally and seeing what comes of it.

@witchlliee
witchlliee marked this pull request as ready for review August 24, 2026 15:35
@witchlliee

Copy link
Copy Markdown
Contributor Author

Enabled dbus mainloop support for firewalld-applet.

@Jaredy899 Jaredy899 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more things. Sorry!

Comment thread f/firewalld/stone.yaml Outdated
Comment thread p/python-pyqt6/stone.yaml
@Jaredy899

Copy link
Copy Markdown
Contributor

I'm going to assign this to Reilly to approve considering how substantial this package is.

@Jaredy899 Jaredy899 added the Needs Rebase One commit or more needs a rebase. label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Rebase One commit or more needs a rebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Package Request]: firewalld

3 participants