Skip to content

Load NyxID recommended skill refs - #3665

Open
louis4li wants to merge 2 commits into
feature/integratefrom
feat/2026-09-18_nyxid-recommended-skill-read
Open

louis4li wants to merge 2 commits into
feature/integratefrom
feat/2026-09-18_nyxid-recommended-skill-read

Conversation

@louis4li

Copy link
Copy Markdown
Contributor

Issue

Closes #3661

Scope

  • Add typed NyxID connected-service recommended skill refs to the inventory contract and parser.
  • Expose a Channel-only nyxid_load_recommended_skill reader that revalidates sender inventory, loads exact Ornn refs, and verifies manifest digests.
  • Update Channel prompt guidance and focused tests for exact recommended-skill loading.
  • Refresh the NyxID assistant conformance Aevatar source pin required by the architecture guard.

Verification

  • dotnet build agents/Aevatar.GAgents.NyxidChat/Aevatar.GAgents.NyxidChat.csproj --nologo
  • dotnet test test/Aevatar.AI.Tests/Aevatar.AI.Tests.csproj --nologo --filter "NyxIdServiceInstanceClientTests|NyxIdConnectedServiceToolSourceTests"
  • dotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo --filter ChannelNyxIdConnectedServiceInventoryToolSourceTests
  • bash tools/ci/test_stability_guards.sh
  • bash tools/ci/architecture_guards.sh
  • Live NyxID deployment endpoint check: not run locally; requires deployed NyxID inventory exposing non-empty recommended_skill_refs.

Notes

  • The loader does not fall back to display names, latest versions, hidden catalog backfill, or raw proxy calls.
  • The recommended skill document is loaded as guidance only; service execution still goes through admitted connected-service tools and frozen schemas.

Generated with Claude Code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-18T04:48:35.301017Z a63449f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a63449f88d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant