Merged
Conversation
rookiejet
force-pushed
the
fix_deprecations
branch
from
6d6e0db to
8f6cf7a
Compare
Contributor
|
Interesting I also fixed the pkg_resources one here: https://github.com/afewmail/afew/pull/363/files But I made them also compatible with python 3.10. |
Contributor
Author
|
3.9 has since been EOL'd from when I first submitted this, but I can drop the pkg_resources change and defer to your PR if 3.9 compat is still desired. Your patch also reminded me that I had not specified minimum python version in this PR, which should be 3.10+. |
Collaborator
|
Hey @rookiejet |
rookiejet
force-pushed
the
fix_deprecations
branch
from
8f6cf7a to
4eda979
Compare
Contributor
Author
|
@GuillaumeSeren Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importlib.metadatainstead ofpkg_resourcesas the latter has been deprecated and is set to be removed by end of 2025: Setuptools should not rely on pkg_resources pypa/setuptools#3085This fixes:
pkg_resourcesto be deprecated #360glob.glob1call as its use has been deprecated in python 3.13+: Deprecate glob.glob0() and glob.glob1() python/cpython#117337