Skip to content

Optimize set! DSL (Round 2) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moberegger merged 3 commits into from
Jun 18, 2025
Merged

Optimize set! DSL (Round 2) #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcf916c
Use block parameter
moberegger Jun 17, 2025
e084853
Pass block parameter
moberegger Jun 17, 2025
b20594c
Style refactor
moberegger Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/jbuilder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,16 +239,16 @@ def target!

alias_method :method_missing, :set!

def _set(key, value = BLANK, attributes = nil)
result = if ::Kernel.block_given?
def _set(key, value = BLANK, attributes = nil, &block)
result = if block
if _blank?(value)
# json.comments { ... }
# { "comments": ... }
_merge_block(key) { yield self }
_merge_block key, &block
else
# json.comments @post.comments { |comment| ... }
# { "comments": [ { ... }, { ... } ] }
_scope { _array(value) { |element| yield element } }
_scope { _array value, &block }
end
elsif attributes.blank?
if ::Jbuilder === value
Expand Down