fix(attestation): drop trailing @ in agentIdentity.binary when version empty#93
Merged
Merged
Conversation
…n empty CreateActionAttestation formatted the binary field as "%s@%s" (Name, Version), so peer-cred-attested attestations — where Version is intentionally empty — emitted strings like "socat1@" with a trailing @. Now only appends "@<version>" when Version is non-empty, matching the canonical-string code in internal/identity/agent.go. Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
manzil-infinity180
force-pushed
the
fix/attestation-binary-trailing-at-92
branch
from
aa18ab3 to
2e40c08
Compare
There was a problem hiding this comment.
Pull request overview
Fixes the attestation predicate formatting for agentIdentity.binary to avoid emitting a trailing @ when the discovered binary version is empty (notably in the kernel-attested peer-cred identity path).
Changes:
- Update
CreateActionAttestationto only append@<version>whenBinary.Versionis non-empty. - Add a regression test ensuring
agentIdentity.binarydoes not end with@when the version is empty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/attestation/signer.go | Adjusts agentIdentity.binary string construction to avoid trailing @ when version is empty. |
| internal/attestation/signer_test.go | Adds a regression test covering the empty-version binary formatting behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Symmetric edge case to the empty-Version dangling @: if Name is missing but Version was defaulted, the predicate would emit a leading "@0.0.0". Now require both halves to be non-empty before joining. Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92.
Attestation predicate emitted "name@" with a trailing @ when
Binary.Versionwas empty (the kernel-attested peer-cred path leaves Version empty intentionally — Digest is the authoritative version). Now mirrors the conditional already ininternal/identity/agent.go.