fix(build): wire commandrun/ebpf submodule to unbreak Linux CI#22
Open
colek42 wants to merge 1 commit into
Open
fix(build): wire commandrun/ebpf submodule to unbreak Linux CI#22colek42 wants to merge 1 commit into
colek42 wants to merge 1 commit into
Conversation
…ild) rookery split the eBPF code into its own Go submodule at plugins/attestors/commandrun/ebpf. cilock-action's go.mod had no require/ replace for it, so any Linux build (tracing_ebpf_linux.go is build-tagged linux) failed with "missing go.sum entry for .../commandrun/ebpf" — this is why main's Build (linux/amd64, linux/arm64) checks are currently red. Add the require + local replace (matching every other rookery sibling) and run go mod tidy so go.sum gains the submodule's transitive deps (github.com/cilium/ebpf and friends). Linux build now resolves. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's
Build (linux/amd64)andBuild (linux/arm64)checks are currently red. They fail with:rookery split its eBPF code into a separate Go submodule
(
plugins/attestors/commandrun/ebpf), but cilock-action'sgo.modneveradded a
require/replacefor it.tracing_ebpf_linux.gois build-taggedlinux, so every Linux build of cilock-action against current rookery breaks.(macOS/Windows builds don't compile that file, which is why only the Linux
checks are red.)
Fix
require+ localreplacefor.../commandrun/ebpf(same pattern asevery other rookery sibling module).
go mod tidysogo.sumpicks up the submodule's transitive deps(
github.com/cilium/ebpfet al).Minimal diff:
go.mod+3/-1,go.sum+12.Verification
GOOS=linux go build ./cmd/cilock-action→ exit 0 (was failing).go build ./...+go test ./internal/...green on the default arch.This unblocks main's CI and is a prerequisite for any new release (the same
drift would block the release build).
🤖 Generated with Claude Code