fix(release): mkdir dist/ before the dogfood attestation write (rc6)#269
Merged
Conversation
rc5 dogfood failed: 'open ../dist/linux-amd64.attestation.json: no such file or directory'. Previously `go build -o ../dist/cilock` created dist/ as a side effect; rc5 moved the binary build INSIDE the workdir (so the product attestor captures it), so nothing created dist/ before cilock wrote the attestation there. The dogfood failed -> fallback (no attestation) -> publish gate rejected. Explicitly `mkdir -p ../dist` before the run. Validated locally: the full dogfood sequence (mkdir + run + build-in-workdir + mv) writes the attestation, captures a non-empty single-leaf products tree, and the binary verifies. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rc5's dogfood
cilock runfailed withopen ../dist/linux-amd64.attestation.json: no such file or directory→ fallback (no attestation) → publish gate rejected.Cause: rc5 moved the binary build inside the workdir (
-o cilock, so the product attestor captures it). Previouslygo build -o ../dist/cilockhad createddist/as a side effect; now nothing did before cilock wrote the attestation to../dist/. One-line fix:mkdir -p ../distbefore the run.Validated locally end-to-end: mkdir + run + build-in-workdir + mv writes the attestation, captures a non-empty single-leaf products tree, binary verifies against the v0.3 policy.
This is the last piece of the build→attest→verify chain (rc5 proved capture+verify+policy; rc6 fixes the dist/ precondition). After merge: re-tag
v2.0.0-rc6.