fix(install.sh): script-scope tmpdir so the EXIT trap doesn't trip set -u#273
Closed
manzil-infinity180 wants to merge 1 commit into
Closed
fix(install.sh): script-scope tmpdir so the EXIT trap doesn't trip set -u#273manzil-infinity180 wants to merge 1 commit into
manzil-infinity180 wants to merge 1 commit into
Conversation
Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The installer aborts with
bash: tmpdir: unbound variable(exit 1) after a successful install:Root cause
install.shruns underset -euo pipefail.tmpdirwas declaredlocalinsidemain(), but the cleanuptrap … EXITfires in the global scope aftermainreturns — where that local no longer exists. With-u(nounset), expanding the now-unset$tmpdiraborts the script.Two consequences: the temp dir is never cleaned up (the
rmnever runs on the real path), andcurl … | bashexits non-zero even though the binary installed fine — breaking any caller that checks the exit code.Fix
Declare
tmpdirat script scope (notlocal) and register acleanup()EXIT trap once at the top, so the trap can see the real path and remove it.${tmpdir:-}guards early exits.Verification
Minimal repro of the two patterns under
set -u:tmpdir: unbound variable, exit 1 (matches the report).bash -npasses.