feat(plugin): expose dev server ready hook - #92
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
📝 WalkthroughWalkthroughThe PR adds ChangesDevelopment server readiness
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DevSupervisor
participant DevSession
participant Plugin
participant CLIShortcuts
DevSupervisor->>DevSession: activate current development session
DevSession->>Plugin: call devServerReady with origin and signal
Plugin-->>DevSession: complete or reject
DevSupervisor->>CLIShortcuts: bind shortcuts for current session
DevSupervisor->>DevSession: close or replace session
DevSession->>Plugin: abort pending hook and await settlement
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bind CLI shortcuts independently from devServerReady activation and prevent stale asynchronous contributions from blocking or rebinding across Session replacement. Clarify cooperative cancellation semantics and extend Supervisor lifecycle coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
DevServerReadyContextandPluginHooks.devServerReady()lifecycle API withoriginand a Session-scopedAbortSignal.controller.done; shutdown and controller failure abort pending hook work before disposal.beforeBuild()/afterBuild(), and document that no ordering is guaranteed.Validation
npm run check-typesnpm run lintnpm testnpm --workspace evjs-docs run buildgit diff --checkRisk / rollout
signalcan delay Session replacement or shutdown.Reviewer notes
_internal/buildimports, and bundler config recomposition used only to discover the actual origin.Summary by CodeRabbit
New Features
devServerReady()plugin lifecycle hook.Documentation