Fixed side effect from invocation of cleaner in unfluff.lazy#21
Open
franza wants to merge 3 commits intoageitgey:masterfrom
franza:master
Open
Fixed side effect from invocation of cleaner in unfluff.lazy#21franza wants to merge 3 commits intoageitgey:masterfrom franza:master
franza wants to merge 3 commits intoageitgey:masterfrom
franza:master
Conversation
Owner
|
Thanks for catching this! I'll take a look in detail when I have some time this weekend. |
Contributor
Author
|
Sure. If you have ideas how we can avoid reloading document bring it up. |
Owner
|
Sorry, I've been lax on reviewing this. Still plan to get to this very soon. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was sure that I checked that for #16 but it seems that I missed that.
cleanermutates originaldocobject sodocneeds to be re-calculated. So right now aftercleaneris applied we will suffer from side effect. Consider next example:Using this code over
test_tags_kexp.htmlfixture we will have different results fortags()sincecleaneris called insidetext().So when
cleaneris called we need to reload document. Besides, I added some refactoring.