Removes embedded Instagram posts from articles#72
Open
peterwilli wants to merge 1 commit intoageitgey:masterfrom
Open
Removes embedded Instagram posts from articles#72peterwilli wants to merge 1 commit intoageitgey:masterfrom
peterwilli wants to merge 1 commit intoageitgey:masterfrom
Conversation
Owner
|
This looks pretty reasonable to me. Can you add a test case for it with one of the affected articles? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes embedded Instagram posts from articles (which are often in a different language) (test article: http://www.huffingtonpost.com/entry/asian-models-victorias-secret-fashion-show_us_58420596e4b09e21702ec3e9)
Before fork, the
text-variable held:But after this change, it's:
I had to create a new filter function (see
cleanSelector), as I couldn't find a existing function to do this. Feedback is welcome 👍