Migrate all shell to the go setup - #1705
Open
Bowei Du (bowei) wants to merge 3 commits into
Open
Bowei Du (bowei) wants to merge 3 commits into
Bowei Du (bowei) wants to merge 3 commits into
Conversation
Bowei Du (bowei)
requested review from
Aditya Shantanu (aditya-shantanu) and
Anna Pendleton (annapendleton)
September 17, 2026 05:54
| BENCHMARK_WORKER_COUNT="${prescan_args[i]#*=}" | ||
| --benchmark-worker-count=*) BENCHMARK_FLAGS+=("--worker-count=${prescan_args[i]#*=}") ;; | ||
| --benchmark-worker-count) | ||
| BENCHMARK_FLAGS+=("--worker-count=${prescan_args[i+1]:-1}") |
Collaborator
There was a problem hiding this comment.
Every sibling flag errors on a missing value, but this one silently falls back to 1 — a truncated --benchmark-worker-count at the end of the line deploys one worker instead of failing. Match the siblings' bounds check.
Bowei Du (bowei)
added
kind/cleanup
Anna Pendleton (annapendleton)
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate all shell scripts to call the ate-setup instead.
After a week, we will delete the shell scripts.
Note: this code was heavily generated.