ate-setup: keep an existing SandboxConfig on deploy - #1721
Open
Haven Xia (HavenXia) wants to merge 1 commit into
Open
Haven Xia (HavenXia) wants to merge 1 commit into
Haven Xia (HavenXia) wants to merge 1 commit into
Conversation
Deploy ate-system re-applied sandboxconfig-gvisor.yaml every run, so an upgrade could overwrite the operator's SandboxConfig and change the sandbox runtime with it. For GA a system upgrade does not touch the runtime, so the default is now created only when missing.
Bowei Du (bowei)
added
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy
ate-systemre-appliedsandboxconfig-gvisor.yamlon every run, so a system upgrade could overwrite the user'sSandboxConfigand change the sandbox runtime with it.For GA a system upgrade does not touch the sandbox runtime, so the default is now created only when missing.
Part of #1686.