Conversation
Deduplicate volume plugin lookup logic across cmd/ateapi and cmd/atelet by introducing internal/volume.LookupPlugin. Preserves gRPC NotFound status codes when wrapping lookup failures.
Add OpenAPI regex and length constraints on ControllerEndpoint in the CSIDriverConfig CRD and add runtime URI and port range validation in the CSI client package.
Query ControllerGetCapabilities and NodeGetCapabilities once during plugin initialization and cache the results. Guard attach, detach, and staging operations against missing driver capabilities to avoid unnecessary RPC overhead and Unimplemented errors.
Remove the SharedInformerFactory from atelet which ran a persistent cluster-wide watch on CSIDriverConfig CRDs. Replace it with a direct client-go Get cached in memory on first use.
Add VolumeAccessMode enum and PublishContext fields to external volume protos. Propagate PublishContext from ControllerPublishVolume through the control-plane actor record to worker node stage and mount operations, and configure CSI volume capabilities according to the requested access mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1077
This PR implements the follow up improvements from PR #552 across 5 commits:
cmd/ateapiandcmd/atelet.Getcached per worker.VolumeAccessModeenum and propagatesPublishContextfromControllerPublishVolumeto node mounts.Testing
make test)make verify,kube-api-linter,metrics.sh)