Add ActorDirs message to carry per-actor directories - #1730
Open
Haven Xia (HavenXia) wants to merge 1 commit into
Open
Haven Xia (HavenXia) wants to merge 1 commit into
Haven Xia (HavenXia) wants to merge 1 commit into
Conversation
atelet and both ateoms derive the per-actor directories (bundles, runsc state, pid files, checkpoint and restore state, durable-dir, system-info and CSI volume roots) from the actor UID through the same package, internal/ateompath. Add an ActorDirs message to RunWorkloadRequest, RestoreWorkloadRequest, CheckpointWorkloadRequest and TerminateWorkloadRequest, and have atelet fill it with the directories it prepared.
Haven Xia (HavenXia)
force-pushed
the
ateom-actor-dirs
branch
from
September 18, 2026 00:24
3295471 to
0adaa55
Compare
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
so for dirs that atelet feeds to ateom, let's split those off to a package internal to atelet so we know ateoms are not assuming it? (and vice versa, atelet should stop using ateompath)
there should probably be a third package for the socket paths they share
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today
ateletandateomderive the per-actor directories (oci bundles, runsc state, pid files, checkpoint and restore state, durable-dir, system-info and volume roots) from the actor UID through the same package,internal/ateompath.Add an
ActorDirsmessage to RunWorkloadRequest, RestoreWorkloadRequest, CheckpointWorkloadRequest and TerminateWorkloadRequest, and have atelet fill it with the directories it prepared.This is the first part of #1604 to decouple atelet and ateom shared pathes.