glutton: replace stuck actors on resume/hibernate failure - #1759
Open
Chenyi Wang (chw120) wants to merge 1 commit into
Open
Chenyi Wang (chw120) wants to merge 1 commit into
Chenyi Wang (chw120) wants to merge 1 commit into
Conversation
Chenyi Wang (chw120)
force-pushed
the
fix-glutton-retry-loop-and-actor-reset
branch
from
September 19, 2026 07:39
1c0be50 to
93812a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace broken/stuck
gluttonActorinstances in place whenresume()orhibernate()fails during benchmark iterations.Problem
When
SuspendActorfails (e.g., due to transient GCSResourceExhaustederrors during cold-bucket ramp-up),ate-api-servercan leave the actor permanently stuck inACTOR_STATE_SUSPENDING.Previously,
gluttonUserkept the brokengluttonActorin itsu.actorsslice for the remainder of the benchmark run:hibernate()ignoredSuspendActor/PauseActorerrors.ResumeActorcalls against that slot repeatedly failed withgot: ACTOR_STATE_SUSPENDINGfor the rest of the test, reducing effective concurrency and generating continuous failure noise.Solution
hibernate(),pause(), andsuspend()returnboolindicating whether the operation succeeded.(*gluttonUser).replaceActor(ctx, broken)to delete the broken actor (AnyState: true) and replace its slot inu.actorswith a freshly created actor (sb-<uuid>).user.replaceActor(ctx, actor)initerate()when eitheractor.resume(ctx)oractor.hibernate(ctx)fails.lifecycle_test.go(TestGluttonIterate_ReplacesActorOnResumeFailure).