Guide admins to confirm onboarding source repos after value#1771
Draft
Gandy2025 wants to merge 1 commit into
Draft
Guide admins to confirm onboarding source repos after value#1771Gandy2025 wants to merge 1 commit into
Gandy2025 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
first-tree-welcometo preserve repo provenance: declared team source vs ad-hoc path/URL.agent config add-repo.Why
The welcome flow could use a path or URL for one task but had no explicit bridge from that temporary input to the admin-owned team source-repo setting. The historical post-value confirmation rule had disappeared during the launcher/menu rewrite, while its old eval expectation remained coupled to GitHub App state.
This restores the value-first behavior without putting repo selection back into the onboarding wizard and without giving agents authority to mutate team defaults.
User impact
Admins get one low-friction, post-value confirmation for a repo the agent can identify. Invitees are not sent to admin-only setup, declined repos stay temporary, and existing team sources are not re-confirmed. The resulting team repo remains an explicit admin action in Settings and is available to team agents by default.
Validation
python3 scripts/quick_validate_skill.py skills/first-tree-welcomepnpm --filter @first-tree/skill-evals exec vitest run src/suites/first-tree-welcome/__tests__— 47 passedpnpm --filter @first-tree/skill-evals typecheckpnpm --filter @first-tree/skill-evals eval:floor -- --suite first-tree-welcomefirst-tree-welcome-ad-hoc-repo-after-value-periodic— passedpnpm check— passed with existing repository warnings onlypnpm typecheck— passedpnpm test— welcome/skill-evals passed; one unrelated bundled-Codex capability test timed out under the parallel full suite, then passed in isolation (1 passed, 50 skipped)