Implement MCP schema contracts and serializers - #66
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_servercontract layer with typed request/response models, typed MCP error payloads, bounded forgetting and contradiction responses, andget_memory(memory_type, record_id)routingBreaking API shape changes
MemoryRecordModel, so non-applicable fields are present asnullinstead of being omitted entirelycontradiction_check,contradiction_check_order,total_contradictions, andcontradictions_truncateddisplayed_decisions,total_decisions, anddecisions_truncated, and thealready_runningbranch is shaped through the same modelsuperseded_byis now exposed for semantic records through the shared serializerFrontend impact
record.steps, so the newnullfields do not break that UI pathweb/src/lib/api.tsto reflect the new nullability and contradiction/forgetting metadata fields explicitlyTesting
./.venv/bin/python -m pytest -q tests/test_mcp_schemas.pytimeout 30s ./.venv/bin/python -m pytest -q tests/test_api_runtime_edges.pytimeout 30s ./.venv/bin/python -m pytest -q tests/test_forgetting_integration.py -k semantic_store_returns_potential_contradictions./.venv/bin/python -m pytest -q tests/test_api.py -k "best_procedures_endpoint_returns_ranked_results or store_semantic_and_query_mixed_results"Closes #60