Skip to content

feat: expose permission mode kinds - #430

Merged
nikita-ashihmin merged 1 commit into
agentclientprotocol:mainfrom
nikita-ashihmin:codex/acp-mode
Aug 24, 2026
Merged

feat: expose permission mode kinds#430
nikita-ashihmin merged 1 commit into
agentclientprotocol:mainfrom
nikita-ashihmin:codex/acp-mode

Conversation

@nikita-ashihmin

Copy link
Copy Markdown
Collaborator

Summary

  • expose ACP permission mode kinds in session mode metadata
  • preserve the mode kind when constructing Codex thread settings
  • update unit and end-to-end coverage for the advertised modes

Testing

  • npm run typecheck
  • npx vitest run src/__tests__/CodexACPAgent/CodexAcpClient.test.ts src/__tests__/CodexACPAgent/session-config-options.test.ts

Expose Codex permission presets with the same wording and review behavior as
the desktop client. Preserve the existing agent and full-access mode IDs,
and add a new ID only for explicit user review.
@nikita-ashihmin
nikita-ashihmin merged commit 50f69e5 into agentclientprotocol:main Aug 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant