Add eidetic remember/recall memory skills#11
Merged
Conversation
- **Vendored the `remember` + `recall` memory skills from eidetic-cli** (cite-don't-import) — the write/read halves of eidetic's shared `~/.eidetic/memory` surface, so this agent (Claude and its colleague backend) can persist facts across sessions and recall them later, sharing one store. `remember` drives `eidetic remember` (idempotent upsert of one JSON record or an NDJSON batch on stdin, dedup by id + content hash); `recall` drives `eidetic recall` with four search modes — exact / approximate / keyword / hybrid — each hit carrying text, full provenance metadata, a relevance score, and a freshness signal. The `.sh` wrappers are byte-verbatim from eidetic-cli (their first-party origin); each `SKILL.md` is localized only in the illustrative `--scope <nick>` examples (Provenance keeps "First-party to eidetic-cli"). Both default to this agent's PRIVATE scope, reading the suffix from `culture.yaml`. Runtime dep: the `eidetic` CLI on PATH (else a local eidetic-cli checkout with `uv`). Propagated by rollout-cli's `eidetic-memory` recipe.
PR Summary by QodoVendor eidetic remember/recall skills for shared persistent memory Description
Diagram
High-Level Assessment
Files changed (6)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
10 rules 1. Skill references home-dir store
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+9
to
+12
| # The store is the files backend at ~/.eidetic/memory by default — a home-dir | ||
| # path OUTSIDE any git worktree, so Claude and the colleague backend (which runs | ||
| # in throwaway worktrees) read the SAME memories. Set EIDETIC_DATA_DIR to opt out | ||
| # of sharing; set EIDETIC_MONGO_URI / NEO4J_URI + --backend for a server store. |
There was a problem hiding this comment.
1. Skill references home-dir store 📘 Rule violation ✧ Quality
The new skill documentation and scripts include the literal home-directory path ~/.eidetic/memory, which points outside the repository and is non-portable across environments. Skill artifacts must avoid external filesystem path literals (including ~/home paths) and instead use repo-local paths or describe external defaults via environment variables or generic wording to prevent compliance and CI lint failures.
Agent Prompt
## Issue description
Remove the literal tilde home-directory path `~/.eidetic/memory` from newly added/updated skill artifacts (docs and scripts), because it references outside the repository and is non-portable, and it also triggers the portability-lint CI rule.
## Issue Context
Skill compliance (PR Compliance IDs 423932 and 423844) disallows absolute paths, `~`, and other outside-repo filesystem path literals in skill directories and committed documentation/config artifacts. CI runs `bash .claude/skills/pr-review/scripts/portability-lint.sh --all`, which flags `~/\.[A-Za-z]` patterns in committed `.md/.yaml/.toml/.json`, and `~/.eidetic/...` is not an exempt carve-out. If the skill needs to mention a default location, describe it without a literal path (e.g., “in the user’s home directory”) and/or refer to an environment variable such as `EIDETIC_DATA_DIR`.
## Fix Focus Areas
- .claude/skills/recall/SKILL.md[12-16]
- .claude/skills/recall/SKILL.md[32-35]
- .claude/skills/recall/SKILL.md[171-175]
- .claude/skills/remember/SKILL.md[11-16]
- .claude/skills/remember/SKILL.md[25-29]
- .claude/skills/recall/scripts/recall.sh[9-12]
- .claude/skills/remember/scripts/remember.sh[15-19]
- CHANGELOG.md[12-26]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors eidetic-cli's first-party
remember+recallmemory skills into this repo's.claude/skills/kit (cite-don't-import), giving this agent a shared, persistent memory surface (~/.eidetic/memory) that Claude and the colleague backend both read and write.remember→eidetic remember: idempotent upsert of one JSON record or an NDJSON batch on stdin (dedup by id + content hash).recall→eidetic recall: four search modes (exact / approximate / keyword / hybrid), each hit carrying text, full provenance metadata, a relevance score, and a freshness signal.The
.shwrappers are byte-verbatim from eidetic-cli (their first-party origin); this repo'sSKILL.mdscope examples are localized to its own nick. Version bumped + CHANGELOG updated per the AgentCulture rule. Runtime dep: theeideticCLI on PATH (else a local eidetic-cli checkout +uv).Propagated by rollout-cli's
eidetic-memoryrecipe (origin: agentculture/eidetic-cli). Squash-merge at your discretion.🤖 Generated with Claude Code