add zero code exemples for anthropic#100
Open
ossama-ferjani wants to merge 2 commits intoagentevals-dev:mainfrom
Open
add zero code exemples for anthropic#100ossama-ferjani wants to merge 2 commits intoagentevals-dev:mainfrom
ossama-ferjani wants to merge 2 commits intoagentevals-dev:mainfrom
Conversation
krisztianfekete
requested changes
Apr 2, 2026
| messages=messages, | ||
| ) | ||
|
|
||
| if response.stop_reason == "end_turn": |
Contributor
There was a problem hiding this comment.
There are many other stop reasons, please handle those as well according to best practices of the underlying framework.
|
|
||
| while True: | ||
| response = client.messages.create( | ||
| model="claude-haiku-4-5-20251001", |
Contributor
There was a problem hiding this comment.
Can we make sure not to pin a very old model?
|
|
||
|
|
||
| def run_agent(client: anthropic.Anthropic, query: str) -> str: | ||
| messages = [{"role": "user", "content": query}] |
Contributor
There was a problem hiding this comment.
Just like in #101, I think we are not handling message history properly. Please make sure we are doing this properly according to the library's conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #41