fix(docs-ci): make docs_dir rewrite robust to CRLF#33
Merged
Conversation
The Docs workflow rewrites `docs_dir: .` to `.docs_build` with sed, but the
committed mkdocs.yml has CRLF line endings, so the anchored `\.$` no longer
matched on the Linux runner. docs_dir stayed as the repo root and mkdocs aborted
("site_dir within docs_dir"), failing every docs deploy since. Strip CR before
sed so the match works regardless of line endings.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docs workflow's
sed 's|^docs_dir: \.$|...|'stopped matching because the committedmkdocs.ymlis CRLF, sodocs_dirstayed as the repo root and mkdocs aborted ("site_dir within docs_dir"). Every docs deploy has failed since. Fix:tr -d '\r'before sed. Verified locally.Follow-up (separate): the repo is uniformly CRLF; a
.gitattributeswitheol=lf+ renormalize would prevent this class of issue, but that's a large diff left for its own PR.🤖 Generated with Claude Code