fix(rag): Add missing payload for ElasticsearchStore#1048
Open
guanxuc wants to merge 5 commits intoagentscope-ai:mainfrom
Open
fix(rag): Add missing payload for ElasticsearchStore#1048guanxuc wants to merge 5 commits intoagentscope-ai:mainfrom
guanxuc wants to merge 5 commits intoagentscope-ai:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
LearningGp
requested changes
Apr 13, 2026
Collaborator
LearningGp
left a comment
LearningGp
left a comment
There was a problem hiding this comment.
Write path looks good (L408-L411), but mapFromEsHit() misses the payload. It's still using the 3-arg constructor instead of retrieving the payload from the ES hit source.
Contributor
Author
|
@LearningGp Thanks for your review, I have updated the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.11
Description
ElasticsearchStoreChecklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)