fix(model): parse non-standard rate limit errors in OpenAIClient to enable auto-retries#1210
Open
jujn wants to merge 2 commits intoagentscope-ai:mainfrom
Open
fix(model): parse non-standard rate limit errors in OpenAIClient to enable auto-retries#1210jujn wants to merge 2 commits intoagentscope-ai:mainfrom
jujn wants to merge 2 commits intoagentscope-ai:mainfrom
Conversation
…nable auto-retries
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #761 by ensuring OpenAI-compatible “gateway” responses that embed rate-limit errors in a non-standard shape (e.g., {code, message, status}) are detected and surfaced as proper OpenAI exceptions so the auto-retry logic can trigger.
Changes:
- Extend
OpenAIResponseto capture non-standard error fields (code,message,status) and treat them as errors viaisError(). - Update
OpenAIClientto prefer outer-layercode/messagewhen standarderroris absent, and to map"429"body codes to HTTP 429 for retry classification. - Add/extend unit tests to cover non-standard error detection in both sync and streaming flows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/model/OpenAIClient.java | Improves error extraction and attempts to classify non-standard 429 bodies as rate-limit exceptions. |
| agentscope-core/src/main/java/io/agentscope/core/formatter/openai/dto/OpenAIResponse.java | Adds non-standard error fields and broadens isError() detection. |
| agentscope-core/src/test/java/io/agentscope/core/model/OpenAIClientTest.java | Adds regression tests for non-standard 429 errors in sync and streaming. |
| agentscope-core/src/test/java/io/agentscope/core/formatter/openai/dto/OpenAIResponseTest.java | Adds focused tests for standard vs non-standard error detection. |
agentscope-core/src/main/java/io/agentscope/core/model/OpenAIClient.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/formatter/openai/dto/OpenAIResponse.java
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #761
Fixes an issue where non-standard gateway errors were swallowed in OpenAIClient, ensuring rate limit (429) errors correctly trigger the auto-retry mechanism.
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)