feat(path): add total path distance display#198
Open
codemonkeybr wants to merge 1 commit into
Open
Conversation
Sum the haversine distance from sender through each repeater to the bot and append it to the path response. Silently omitted when any node in the chain has unknown coordinates. Controlled by show_path_distance config flag (default: true). Add distance_traveled translation key for all 10 supported locales.
Author
|
Dear maintainer, dont merge just yet. im running some live tests on my local mesh with other folks helping me, i think there is a bug. |
Author
|
Someone has reported a bug, but aint a bug, was an expected behaviour, sender didnt have coords enable on adverto so bot didnt count the sender -> repeater distance. Good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathcommand responseshow_path_distanceconfig flag (default:true)distance_traveledtranslation key for all 10 supported locales (de, en-GB, es, fr, fr-CA, nl, pl, pt-BR, pt, en)Example output:
Test plan
pathcommand from a node with known coordinates through repeaters with known coordinates — distance line should appearpathcommand where one repeater has no coordinates in DB — distance line should be silently omittedshow_path_distance = falsein config — distance line should never appear