[Draft] Preliminary review of lanai code changes#1
Draft
aghaisas wants to merge 1030 commits into
Draft
Conversation
Reviewed-by: lancea, joehw
Reviewed-by: zgu, iklam
…ng/plaf/nimbus/doc-files/properties.html Reviewed-by: serb, aivanov
kevinrushforth
left a comment
kevinrushforth
left a comment
There was a problem hiding this comment.
I left a few inline comments. Here are a couple global ones:
- Several files are missing copyright headers. I have scripts that will fix them, so I will volunteer to do that. I can update the copyright years to 2021 at the same time if there are no objections.
- I see several files with wildcard imports. Do we want to eliminate (expand) these?
| PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF | ||
| LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING | ||
| NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
| SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
There was a problem hiding this comment.
Question for Phil: is a BSD license OK for this build script? The rest of the files are GPL.
mrserb
suggested changes
Jan 28, 2021
mrserb
reviewed
Jan 28, 2021
mrserb
reviewed
Jan 28, 2021
mrserb
reviewed
Jan 28, 2021
mrserb
reviewed
Jan 28, 2021
avu
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.