Skip to content

Support Multi-UBI Vols#14

Open
denverwilliams wants to merge 1 commit intoagherzan:masterfrom
denverwilliams:Resin-Support
Open

Support Multi-UBI Vols#14
denverwilliams wants to merge 1 commit intoagherzan:masterfrom
denverwilliams:Resin-Support

Conversation

@denverwilliams
Copy link
Copy Markdown

No description provided.

@jenkins-ag
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Comment thread classes/ubi_multi_vol-chip.bbclass Outdated

# This variable is available to request which values are suitable for IMAGE_FSTYPES
IMAGE_TYPES = " \
multiubivol \ No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dlx, shouldn't this line be terminated with a double quote? Would it also be possible to make the indentation consistent?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michal-mazurek Indentation should be better now.

Comment thread classes/ubi_multi_vol-chip.bbclass Outdated
init_config_json ${WORKDIR}

cp ${WORKDIR}/config.json ${RESIN_BOOT_DIR}/config.json.init

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dlx can you squash these 2 commits in 1?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping on this @dlx ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@floion Commits Squashed

@denverwilliams denverwilliams force-pushed the Resin-Support branch 4 times, most recently from e29f95e to bf33663 Compare July 14, 2017 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants