fix(#81): correct sidebar-test guidance to match #183 (fast gate runs it in-loop)#199
Open
agjs wants to merge 1 commit into
Open
fix(#81): correct sidebar-test guidance to match #183 (fast gate runs it in-loop)#199agjs wants to merge 1 commit into
agjs wants to merge 1 commit into
Conversation
…runs it in-loop) The refine prompt told the model a stale sidebar nav-count fails only "the final full-project validate". Since #183 the FAST per-feature gate runs the sidebar's co-located test (`bun run test -- run … src/components/core/AppSidebar`), so a stale count fails IN-LOOP every cycle. The old wording understated the urgency and could let the model defer the one-line count bump and spray the fast gate. Corrected to say the per-feature gate fails THIS cycle, not only the final validate. Pins the claim with two assertions (present: "per-feature gate fails THIS cycle"; absent: the old final-validate wording) so it can't silently regress. refine-prompt suite 36 pass; typecheck+lint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refine prompt told the model a wrong sidebar nav-link count fails only "the final full-project validate". Since #183 the FAST per-feature gate runs the sidebar's co-located test (
bun run test -- run … src/components/core/AppSidebar), so a stale count fails IN-LOOP every cycle — the old wording understated the urgency and could let the model defer the one-line count bump and spray the fast gate.Corrected to say the per-feature gate fails THIS cycle, not only the final validate. Pinned with two assertions (present: "per-feature gate fails THIS cycle"; absent: the old final-validate wording) so it can't silently regress.
Panel: PASS (4/4, no findings). refine-prompt suite 36 pass; typecheck + lint clean.