fix: show falsy sample values instead of NULL in introspect_schema#27
Open
Osamaali313 wants to merge 1 commit into
Open
fix: show falsy sample values instead of NULL in introspect_schema#27Osamaali313 wants to merge 1 commit into
Osamaali313 wants to merge 1 commit into
Conversation
The sample-row renderer used `str(v)[:30] if v else "NULL"`, so any falsy column value (0, 0.0, False, empty string, Decimal('0')) was displayed as NULL. A row of (0, '', 0, 0.0) rendered as | NULL | NULL | NULL | NULL |, misrepresenting real data to the agent reading the schema.
Only None is NULL; render every other value (including falsy ones) via str(v)[:30].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sample-data renderer in
introspect_schemaformatted each cell with:if vis truthiness, so every falsy column value —0,0.0,False, empty string,Decimal('0')— was displayed asNULL. The agent reading the schema sample then sees missing data where real values exist.Reproduction
Running the real tool against a SQLite table with a row of
(0, '', 0, 0.0):Before
After
Fix
Treat only
NoneasNULL; render every other value (including falsy ones) withstr(v)[:30]: