Fix MTU value type coercion in network config serialization#16
Closed
andrew-jones wants to merge 1 commit into
Closed
Fix MTU value type coercion in network config serialization#16andrew-jones wants to merge 1 commit into
andrew-jones wants to merge 1 commit into
Conversation
…iteral. Without from_yaml, Ansible's implicit type coercion was stringifying the integer 1500 during the conversion. Adding | from_yaml explicitly parses that string into a proper Python dict first, which preserves mtu as an integer 1500. Then | to_json serializes it to "mtu": 1500 (not "1500").
andrew-jones
requested review from
agonzalezrh,
fridim,
rut31337,
stencell and
wkulhanek
as code owners
agonzalezrh
requested changes
Apr 13, 2026
Contributor
agonzalezrh
left a comment
agonzalezrh
left a comment
There was a problem hiding this comment.
Use new EE generated last Friday
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_configvariable is a string resembling a YAML/Python dict literal. Without explicit parsing, Ansible's implicit type coercion was converting the integermtu: 1500into the string"1500"when serialized to JSON. Adding| from_yamlbefore| to_jsonensures the value is first parsed into a proper Python dict, preservingmtuas an integer.Changes
from_yamlfilter beforeto_jsonincreate_network.yamlso that numeric fields likemtuare serialized with their correct types (e.g."mtu": 1500instead of"mtu": "1500")