Add proper tests, fix lint errors.

.ansible-lint

@@ -0,0 +1,34 @@
+---
+profile: production
+
+exclude_paths:
+- tests/
+
+skip_list:
+- galaxy[no-changelog]
+- name[template]
+- var-naming[no-role-prefix]
+- var-naming[pattern]
+- fqcn[action-core]
+- fqcn[canonical]
+- ignore-errors
+- jinja[spacing]
+- risky-file-permissions
+- no-changed-when
+- risky-shell-pipe
+- partial-become
+- no-handler
+- package-latest
+- literal-compare
+- meta-incorrect
+- role-name
+- name[missing]
+- name[casing]
+- command-instead-of-shell
+- no-free-form
+- meta-no-tags
+- galaxy[version-incorrect]
+
+mock_modules:
+- agnosticd.core.agnosticd_user_info
+- agnosticd.core.agnosticd_user_data

.github/workflows/static-checks-push.yml → .github/workflows/static-checks.yml

@@ -1,34 +1,35 @@
 ---
-name: Static Checks Push
+name: Static Checks
 
-on:
+"on":
   push:
     branches:
     - main
     tags:
     - v*
+  pull_request:
+    branches:
+    - main
 
 jobs:
   static-checks:
-    name: Run static tests using tox
+    name: Run yamllint and ansible-lint
     runs-on: ubuntu-latest
     strategy:
       matrix:
         python-version:
         - '3.12'
 
     steps:
-    - name: Get Repository Code
-      id: get_repo_code
-      uses: actions/checkout@v2
+    - name: Checkout repository
+      uses: actions/checkout@v4
 
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
 
     - name: Run static checks
       run: |
         pip install tox
         tox -c tests/static
-...

.yamllint

@@ -0,0 +1,29 @@
+---
+extends: default
+
+ignore:
+- .tox/
+- .git/
+
+rules:
+  braces:
+    min-spaces-inside: 0
+    max-spaces-inside: 1
+  brackets:
+    min-spaces-inside: 0
+    max-spaces-inside: 1
+  comments:
+    require-starting-space: false
+    min-spaces-from-content: 1
+  comments-indentation: disable
+  document-start: false
+  indentation:
+    spaces: 2
+    indent-sequences: consistent
+  line-length:
+    max: 150
+    allow-non-breakable-inline-mappings: false
+  new-line-at-end-of-file: false
+  octal-values:
+    forbid-implicit-octal: true
+    forbid-explicit-octal: true

galaxy.yml

@@ -35,7 +35,8 @@ license_file: ''
 
 # A list of tags you want to associate with the collection for indexing/searching. A tag name has the same character
 # requirements as 'namespace' and 'name'
-tags: []
+tags:
+- cloud
 
 # Collections that this collection requires to be installed for it to be usable. The key of the dict is the
 # collection label 'namespace.name'. The value is a version range
@@ -67,4 +68,3 @@ build_ignore: []
 # 'omit_default_directives' is a boolean that controls whether the default directives are used. Mutually exclusive
 # with 'build_ignore'
 # manifest: null
-

meta/runtime.yml

@@ -1,53 +1,2 @@
-#SPDX-License-Identifier: MIT-0
 ---
-# Collections must specify a minimum required ansible version to upload
-# to galaxy
-# requires_ansible: '>=2.9.10'
-
-# Content that Ansible needs to load from another location or that has
-# been deprecated/removed
-# plugin_routing:
-#   action:
-#     redirected_plugin_name:
-#       redirect: ns.col.new_location
-#     deprecated_plugin_name:
-#       deprecation:
-#         removal_version: "4.0.0"
-#         warning_text: |
-#           See the porting guide on how to update your playbook to
-#           use ns.col.another_plugin instead.
-#     removed_plugin_name:
-#       tombstone:
-#         removal_version: "2.0.0"
-#         warning_text: |
-#           See the porting guide on how to update your playbook to
-#           use ns.col.another_plugin instead.
-#   become:
-#   cache:
-#   callback:
-#   cliconf:
-#   connection:
-#   doc_fragments:
-#   filter:
-#   httpapi:
-#   inventory:
-#   lookup:
-#   module_utils:
-#   modules:
-#   netconf:
-#   shell:
-#   strategy:
-#   terminal:
-#   test:
-#   vars:
-
-# Python import statements that Ansible needs to load from another location
-# import_redirection:
-#   ansible_collections.ns.col.plugins.module_utils.old_location:
-#     redirect: ansible_collections.ns.col.plugins.module_utils.new_location
-
-# Groups of actions/modules that take a common set of options
-# action_groups:
-#   group_name:
-#     - module1
-#     - module2
+requires_ansible: '>=2.16.0'

roles/control_user/meta/main.yml

@@ -3,13 +3,12 @@ galaxy_info:
   author: Mitesh The Mouse
   description: Creates control user
   company: Red Hat
-  version: 1.0.0
   license: license (GPL-3.0)
-  min_ansible_version: 2.7
+  min_ansible_version: '2.16'
   platforms:
     - name: EL
       versions:
-        - 7
+        - all
   galaxy_tags:
     - sudo
     - control

roles/letsencrypt_cert/defaults/main.yml

@@ -5,8 +5,8 @@ letsencrypt_cert_hostname: >-
 letsencrypt_cert_encrypt_mail: "{{ email | default('devops@opentlc.com') }}"
 
 # Define paths to run copy
-# letsencrypt_cert_dest_private_key: 
+# letsencrypt_cert_dest_private_key:
 # letsencrypt_cert_dest_fullchain_crt:
 
 # Default owner is Omit
-# letsencrypt_cert_owner: 
+# letsencrypt_cert_owner:

roles/letsencrypt_cert/tasks/main.yml

@@ -49,7 +49,7 @@
     dest: "{{ letsencrypt_cert_dest_private_key }}"
     remote_src: true
     owner: "{{ letsencrypt_cert_owner | default(omit) }}"
-    mode: 0644
+    mode: "0644"
 
 - name: Copy letsencrypt certificate
   when: letsencrypt_cert_dest_fullchain_crt is defined
@@ -58,4 +58,4 @@
     dest: "{{ letsencrypt_cert_dest_fullchain_crt }}"
     remote_src: true
     owner: "{{ letsencrypt_cert_owner | default(omit) }}"
-    mode: 0644
+    mode: "0644"