Skip reencrypt route config if rhacs-central-tls secret does not exist#142
Merged
Conversation
Move secret check outside the block and update block condition to check both reencrypt_route enabled and secret exists. This prevents failure when the secret is not yet created. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Only include the destinationCACertificate field if the variable is defined. This prevents template errors when rhacs-central-tls secret doesn't exist. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
treddy08
requested review from
agonzalezrh,
fridim,
rut31337,
stencell and
wkulhanek
as code owners
wkulhanek
previously approved these changes
May 1, 2026
Rename ocp4_workload_rhacs_reencrypt_destination_ca to _ocp4_workload_rhacs_reencrypt_destination_ca to indicate it's an internal variable. Skip reencrypt block if variable is not defined. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move secret check outside the block and update block condition to check both reencrypt_route enabled and secret exists. This prevents failure when the secret is not yet created.