Exclude Google Trust Services ClusterIssuers when reencrypt route is enabled#143
Merged
Merged
Conversation
…enabled When ocp4_workload_rhacs_enable_reencrypt_route is set to true, filter out ClusterIssuers that use Google Trust Services (/acme/google/) as they are incompatible with OpenShift reencrypt routes. The role will now prefer ZeroSSL, Let's Encrypt, or other ACME providers for certificate issuance when the reencrypt route feature is enabled, while maintaining existing behavior when reencrypt is disabled.
treddy08
requested review from
agonzalezrh,
fridim,
rut31337,
stencell and
wkulhanek
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ocp4_workload_rhacs_enable_reencrypt_routeis enabledChanges
Modified
roles/ocp4_workload_rhacs/tasks/certificate.yml:/acme/google/in their ACME server URL when reencrypt route is enabledTesting
Tested on clusters with both Google Trust Services and ZeroSSL certificates:
Impact
When
ocp4_workload_rhacs_enable_reencrypt_route: true, the role will automatically use ZeroSSL, Let's Encrypt, or other non-Google ACME providers for certificate issuance.