Fix ClusterIssuer filter to handle non-ACME issuers in RHACS role#144
Merged
Conversation
The previous implementation failed when non-ACME ClusterIssuers (e.g., selfsigned) were present because it attempted to access spec.acme.server on all issuers. Changed from using rejectattr() filter to JMESPath expression that properly handles null values by checking if spec.acme.server exists before testing for Google CA. When reencrypt route is enabled: - Filters out Google Trust Services ACME issuers (/acme/google/) - Keeps all other ACME issuers (ZeroSSL, Let's Encrypt, etc.) - Keeps all non-ACME issuers (selfsigned, ca, vault, etc.) When reencrypt route is disabled: - Keeps all Ready ClusterIssuers (no filtering by CA provider) Tested against cluster with: acme-bifrost-production-ddns (Google), acme-bifrost-production-ddns-fallback (ZeroSSL), and selfsigned.
treddy08
requested review from
agonzalezrh,
fridim,
rut31337,
stencell and
wkulhanek
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation failed when non-ACME ClusterIssuers (e.g., selfsigned) were present because it attempted to access spec.acme.server on all issuers.
Changed from using rejectattr() filter to JMESPath expression that properly handles null values by checking if spec.acme.server exists before testing for Google CA.
When reencrypt route is enabled:
When reencrypt route is disabled:
Tested against cluster with: acme-bifrost-production-ddns (Google), acme-bifrost-production-ddns-fallback (ZeroSSL), and selfsigned.