fail provision with clear message when runtime-automation dir is missing#61
Open
prakhar1985 wants to merge 2 commits into
Open
fail provision with clear message when runtime-automation dir is missing#61prakhar1985 wants to merge 2 commits into
prakhar1985 wants to merge 2 commits into
Conversation
added 2 commits
April 17, 2026 12:39
If a showroom content repo does not include runtime-automation/, podman-compose fails with: statfs /opt/showroom/content/runtime-automation: no such file or directory This causes showroom.service to exit 125 and the OCP pod to be marked not-ready, returning 503 from the router. After cloning the content repo, stat the runtime-automation/ dir. If showroom_ansible_runner_api is true but the directory is absent, set the variable to false so compose_default_template.j2 skips the ansible-runner-api service block entirely.
Instead of silently disabling the runner or letting podman-compose crash at startup with an opaque statfs error, fail early with an actionable message telling the content author exactly what to add.
andrew-jones
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a content author sets
showroom_ansible_runner_api: truein their AgV catalog but forgets to add aruntime-automation/directory to their content repo,podman-composefails silently at startup with:This causes
showroom.serviceto exit 125. The provision appears to succeed but the showroom is unreachable — the OCP pod is marked not-ready and the router returns 503.Root cause: The default for
showroom_ansible_runner_apiisfalse. The failure only occurs when a dev explicitly enables it in their AgV config without providing the requiredruntime-automation/directory in the content repo.Fix
Add an early check in
30-showroom-clone-and-inject.yml(after clone, before compose is rendered) that fails the provision immediately with a clear, actionable message:The stat and fail tasks are both gated on
showroom_ansible_runner_api | bool, so there is zero overhead for the common case where it isfalse.Behaviour
showroom_ansible_runner_apiruntime-automation/in repofalse(default)truetrue