Add destroy action to ocp_console_embed role#71
Open
andrew-jones wants to merge 4 commits into
Open
Conversation
Cover the healthz endpoint (200/503), unknown paths (404), valid admission requests, oversized body rejection (413), malformed JSON fallback to allow, missing UID handling, and exception-in-handler fail-open behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Add all 16 configurable variables from defaults/main.yml to the README, organized into required and optional sections. Add prerequisites (OCP 4.x, kubernetes.core collection) and note that the IngressController patch affects all default-ingress routes. Co-authored-by: Cursor <cursoragent@cursor.com>
…destroy The provision path may scale down router replicas to match schedulable worker nodes, but destroy never cleared the override. Use a JSON merge patch to set spec.replicas to null so the ingress operator resumes managing the replica count. Co-authored-by: Cursor <cursoragent@cursor.com>
andrew-jones
force-pushed
the
remove-workload
branch
from
8429348 to
77007e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
destroyaction to theocp4_workload_ocp_console_embedrole, adopting the standardACTIONdispatcher pattern used by core_workloads roles. This enables clean teardown of the webhook, RBAC, IngressController header customizations, and namespace when the workload is removed.Changes
tasks/main.ymlinto the standardACTION-based dispatcher (provision/destroy)tasks/workload.ymltasks/remove_workload.ymlthat reverses the provision in correct order: removes MutatingWebhookConfiguration, resets IngressController httpHeaders, cleans up RBAC fromopenshift-authentication, deletes the workload namespace, and waits for the OAuth route to revert to passthrough