Support non-binary word vectors in compute-accuracy#8
Open
Witiko wants to merge 1 commit into
Open
Conversation
Author
|
I am sorry, I did not realize the vector file format was a de-facto standard. I suppose a better course of action might be to add a |
442386f to
b7a8906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes adds the
binaryandtextformat identifiers to the header of word vectors to tell the difference between binary and non-binary word vector formats. Thecompute-accuracyscript has been extended to recognize both binary and non-binary word vectors. Binary word vectors without the format identifier are also recognized to remain backwards-compatible.The PR has been successfully tested as follows:
-binary 0on HEAD,-binary 1on HEAD, and-binary 1on HEAD^.compute-accuracyto see if the standard deviation of the total accuracy was below 1%.