Skip to content

Add POINT_ID deep-linking for PLSS point identify state#526

Merged
stdavis merged 6 commits intomainfrom
copilot/add-point-id-url-parameter
Apr 8, 2026
Merged

Add POINT_ID deep-linking for PLSS point identify state#526
stdavis merged 6 commits intomainfrom
copilot/add-point-id-url-parameter

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

  • Review the new PR comment and inspect current usages of the point-id helper
  • Remove the unnecessary getPointIdWhereClause helper and inline the remaining query string at its call site
  • Remove the obsolete helper test while keeping normalizePointId coverage intact
  • Run targeted tests and lint for the affected files
  • Reply to the new review comment with the addressing commit hash

Copilot AI linked an issue Apr 7, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add URL parameter for linking to specific PLSS point Add POINT_ID deep-linking for PLSS point identify state Apr 7, 2026
Copilot AI requested a review from stdavis April 7, 2026 21:26
@stdavis stdavis force-pushed the copilot/add-point-id-url-parameter branch 2 times, most recently from 5c257fc to 3b1002e Compare April 7, 2026 21:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Visit the preview URL for this PR (updated for commit 209da0f):
Firebase Preview: https://ut-dts-agrc-plss-dev--copilot-add-point-id-url-paramet-v91o1f39.web.app
(expires "2026-04-22T17:04:40.228134452Z" )

Comment thread src/components/pageElements/utils.test.js Outdated
stdavis
stdavis previously requested changes Apr 7, 2026
Copy link
Copy Markdown
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's really no purpose for the getPointIdWhereClause function now. Please remove it.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 7, 2026

There's really no purpose for the getPointIdWhereClause function now. Please remove it.

Removed in d39eee1. The query string is now inlined at the only call site and the obsolete helper test is gone. No UI change in this follow-up; existing behavior screenshot: https://github.com/user-attachments/assets/3f9ef150-b0e1-4aab-a968-56ea3c4aada0

@stdavis stdavis marked this pull request as ready for review April 7, 2026 21:52
@stdavis stdavis requested a review from Copilot April 7, 2026 21:53
@stdavis stdavis enabled auto-merge (squash) April 7, 2026 21:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds deep-linking support for the PLSS point Identify workflow by syncing the selected point to a POINT_ID URL parameter and reading it on initial load to auto-identify a point.

Changes:

  • Add normalizePointId helper (and unit tests) for consistent POINT_ID normalization.
  • Update Map.jsx to write POINT_ID on map identify clicks and to auto-query/identify from POINT_ID on initial load.
  • Make PLSS point highlight logic resilient when the PLSS points layer isn’t present in the map.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/components/pageElements/Map.jsx Adds URL param syncing + initial load identify via queryFeatures; hardens highlight behavior when layer is missing.
src/components/pageElements/utils.js Introduces normalizePointId helper used by URL deep-linking.
src/components/pageElements/utils.test.js Adds Vitest coverage for normalizePointId.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/pageElements/Map.jsx
Comment thread src/components/pageElements/Map.jsx
@stdavis stdavis requested a review from jacobdadams April 7, 2026 22:39
@stdavis stdavis force-pushed the copilot/add-point-id-url-parameter branch from d39eee1 to 57bb110 Compare April 8, 2026 17:02
@stdavis stdavis dismissed their stale review April 8, 2026 17:02

completed

@stdavis stdavis deployed to preview April 8, 2026 17:03 — with GitHub Actions Active
@stdavis stdavis disabled auto-merge April 8, 2026 17:09
@stdavis stdavis merged commit cff1bc3 into main Apr 8, 2026
5 checks passed
@stdavis stdavis deleted the copilot/add-point-id-url-parameter branch April 8, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add POINT_ID URL Parameter

4 participants