Add POINT_ID deep-linking for PLSS point identify state#526
Conversation
5c257fc to
3b1002e
Compare
|
Visit the preview URL for this PR (updated for commit 209da0f): |
stdavis
left a comment
There was a problem hiding this comment.
There's really no purpose for the getPointIdWhereClause function now. Please remove it.
Removed in d39eee1. The query string is now inlined at the only call site and the obsolete helper test is gone. No UI change in this follow-up; existing behavior screenshot: https://github.com/user-attachments/assets/3f9ef150-b0e1-4aab-a968-56ea3c4aada0 |
There was a problem hiding this comment.
Pull request overview
Adds deep-linking support for the PLSS point Identify workflow by syncing the selected point to a POINT_ID URL parameter and reading it on initial load to auto-identify a point.
Changes:
- Add
normalizePointIdhelper (and unit tests) for consistent POINT_ID normalization. - Update
Map.jsxto writePOINT_IDon map identify clicks and to auto-query/identify fromPOINT_IDon initial load. - Make PLSS point highlight logic resilient when the PLSS points layer isn’t present in the map.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/components/pageElements/Map.jsx |
Adds URL param syncing + initial load identify via queryFeatures; hardens highlight behavior when layer is missing. |
src/components/pageElements/utils.js |
Introduces normalizePointId helper used by URL deep-linking. |
src/components/pageElements/utils.test.js |
Adds Vitest coverage for normalizePointId. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d39eee1 to
57bb110
Compare
Uh oh!
There was an error while loading. Please reload this page.