Skip to content

Some updates while testing a firewall#412

Merged
steveoh merged 6 commits intomainfrom
dev
Jul 1, 2025
Merged

Some updates while testing a firewall#412
steveoh merged 6 commits intomainfrom
dev

Conversation

@steveoh
Copy link
Copy Markdown
Contributor

@steveoh steveoh commented Jul 1, 2025

  • use agrc/python conventions except for license and the license classifier which is deprecated and should be removed
  • improve caching, security, and docker image size
  • update action version (which i believe is skipped by dbot)

oh and the dev vpc can access the cloud db instance

@steveoh steveoh requested review from Copilot and stdavis July 1, 2025 00:44
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (d397057) to head (0c6514f).
Report is 39 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   90.45%   90.45%           
=======================================
  Files           2        2           
  Lines         419      419           
  Branches       77       65   -12     
=======================================
  Hits          379      379           
  Misses         33       33           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment was marked as outdated.

@steveoh steveoh requested a review from Copilot July 1, 2025 00:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project configuration and Docker build process to align with current agrc/python conventions while improving caching, security, and docker image size.

  • Removed deprecated license classifier from setup.py and updated metadata.
  • Optimized Dockerfile by combining layers and introducing a non-root user along with updated pip installation.
  • Upgraded the Docker build-push action version in the deploy action workflow.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
setup.py Updated package metadata, removed the deprecated license field, and expanded package keywords.
Dockerfile Optimized layer usage with consolidated commands, enhanced security settings, and non-root user setup.
.github/actions/deploy/action.yml Upgraded docker/build-push-action from v5 to v6.
.dockerignore Expanded ignore patterns; ensure ignored files (e.g., LICENSE) are not required during build processes.
Comments suppressed due to low confidence (3)

.github/actions/deploy/action.yml:73

  • Upgrading to docker/build-push-action@v6 may introduce configuration changes; please confirm that all options remain compatible and have been validated in your deployment workflow.
      uses: docker/build-push-action@v6

Dockerfile:48

  • Using '--user' with pip install in a Dockerfile is unconventional; please ensure that /home/dummy/.local/bin is in PATH and that the locally installed dependencies are accessible at runtime.
RUN python -m pip install --user --upgrade pip && \

.dockerignore:42

  • The LICENSE file is ignored in the Docker build context while setup.py uses license_files. Ensure that this exclusion doesn't affect the package distribution if the LICENSE file is required.
LICENSE

@steveoh steveoh enabled auto-merge (rebase) July 1, 2025 00:55
@steveoh steveoh merged commit 519eb96 into main Jul 1, 2025
8 checks passed
@steveoh steveoh deleted the dev branch July 1, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants