Conversation
LegacyKeyValueFormat JSONArgsRecommended
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 90.45% 90.45%
=======================================
Files 2 2
Lines 419 419
Branches 77 65 -12
=======================================
Hits 379 379
Misses 33 33
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project configuration and Docker build process to align with current agrc/python conventions while improving caching, security, and docker image size.
- Removed deprecated license classifier from setup.py and updated metadata.
- Optimized Dockerfile by combining layers and introducing a non-root user along with updated pip installation.
- Upgraded the Docker build-push action version in the deploy action workflow.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Updated package metadata, removed the deprecated license field, and expanded package keywords. |
| Dockerfile | Optimized layer usage with consolidated commands, enhanced security settings, and non-root user setup. |
| .github/actions/deploy/action.yml | Upgraded docker/build-push-action from v5 to v6. |
| .dockerignore | Expanded ignore patterns; ensure ignored files (e.g., LICENSE) are not required during build processes. |
Comments suppressed due to low confidence (3)
.github/actions/deploy/action.yml:73
- Upgrading to docker/build-push-action@v6 may introduce configuration changes; please confirm that all options remain compatible and have been validated in your deployment workflow.
uses: docker/build-push-action@v6
Dockerfile:48
- Using '--user' with pip install in a Dockerfile is unconventional; please ensure that /home/dummy/.local/bin is in PATH and that the locally installed dependencies are accessible at runtime.
RUN python -m pip install --user --upgrade pip && \
.dockerignore:42
- The LICENSE file is ignored in the Docker build context while setup.py uses license_files. Ensure that this exclusion doesn't affect the package distribution if the LICENSE file is required.
LICENSE
stdavis
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oh and the dev vpc can access the cloud db instance