add full name calculation by gregbunce · Pull Request #1 · agrc/utrans-attribute-rules

gregbunce · 2020-12-10T17:16:36Z

just getting things going, so i wanted to check in before i got too far.

steveoh

yeah this looks like you're on the right track

…utrans-attribute-rules into feat/road-name-calculation i realign local with remote

gregbunce · 2020-12-10T21:31:33Z

i made a few changes based on your suggestions. should i mark it as 'ready for review'?

steveoh · 2020-12-14T18:03:54Z

Can you send me or better yet commit the xml schema doc so I can load in the db and test this?

gregbunce · 2020-12-23T18:13:39Z

let me know if you need some data as well. i exported the 'schema only'

gregbunce · 2020-12-23T18:16:24Z

also, the xml schema contains all the needed layers (data store) for the attribute rules. let me know if you only want the roads layer (the layer we're putting the attribute rules on).

steveoh · 2020-12-24T18:19:50Z

also, the xml schema contains all the needed layers (data store) for the attribute rules. l

The schema imported but when I tried to append data to some of the datasets so the rules will function the schema's didn't match and it failed. I ended up having to delete and then copy in the data. Let's do a schema export with data to eliminate these steps.

this might not be the expected behavior

steveoh

This seems to be in a draft state still but going in the right direction.

There are quite a few issues that are frustrating for a reviewer and I will list them so we can have more productive reviews in the future.

The pr text is a bit light. It says you're hoping to be going in the right direction but don't really state the known issues or things you are working out.
You don't mention what the full name calculation is expected to do. We don't have tests yet so some text on expectations would be very helpful.
The ar.py wasn't able to run and add the rules for testing.
The pro project was missing with the connection sde file.
The roads_edit fc was not able to have attribute rules added to it since it is missing global ids.

Otherwise yes it looks like you aren't in the weeds making timely mistakes.

gregbunce · 2020-12-30T17:04:16Z

thanks for the useful feedback and for the work you put into this pr to get it up and running. all good points - and noted on my end.

I'll pull this branch to my local repo. then...

add globalid to roads_edit
replace the existing XML schema with one containing the data.
test your commits
push my local branch back to the remote
'ready for review'

Does that sound right?

thanks again. once i get this set up, i feel as though I'll be able to make more timely progress on the project - doing local testing and a more focused pr.

should i do my local testing using the pro project you added to the repo?

steveoh · 2020-12-30T17:49:42Z

You bet. This branch should already exist in your local repo unless you did all the work in the github.com ui which I doubt. So you can most likely just checkout feat/road-name-calculation if you're not already on it and git pull.

yes
yes
yes and make the necessary changes to make sure the rules are creating the proper results
the commits you make to get the rules properly functioning, yes, you will then push to this existing branch. no need to make any new branches
yes - when everything is working as expected

Yes we should align on that pro project. There might be some broken items, i'm thinking paths etc but we should work that out so we are working on identical items.

gregbunce · 2020-12-30T17:55:15Z

k, perfect. yup, i pulled your changes to my local branch.

i'm trying to work out the pro project now. working on how to use the shared sde connection file. is that possible? it looks like you used os auth.

is there a way we can use a common Instance name or should i just use my local connection string and just work on sharing the pro project? (if that makes sense)

here's how i see your connection file:

steveoh · 2020-12-30T18:11:25Z

let's try to go with the local style as that will work for anyone with a local sql server and won't have any username/passwords in it.

this is now working in arcgis pro testing

and set triggers to update; also rename ar rules to reflect the associated field name

gregbunce · 2021-01-22T22:42:53Z

all of the calculation rules appear to be working in arcgis pro during my manual testing. the next step is to now write some testing in test_roads.py. i put some time aside next week to do so (beginning Monday).

also, currently, we have one constrain rule that we've created (predir_domain_constraint) but there are no domains in the db. how should we handle that? i guess they didn't carry over in the XML schema. i can export the existing domains in utrans (the 'real' utrans) to tables and then we can add them to the local utrans db. does that work?

steveoh

looks like you're on the right track!

steveoh · 2021-03-16T21:57:21Z

@@ -0,0 +1,18 @@
+table = "Roads_Edit"


chore: add this file to the .gitignore please

steveoh · 2021-03-16T21:58:00Z


    ```sh
-    conda create --clone arcgispro-py3 --name utrans
+    conda create --name utrans


praise: niiiiiice!

steveoh · 2021-03-16T22:07:26Z

+sde = os.path.join(os.path.dirname(__file__), '..', 'pro-project', 'localhost@utrans.sde')
 TABLE = os.path.join(sde, table_name)


nitpick: we should switch this to use the newer pathlib which is the recommended library for the future.

something like the following should suffice

Suggested change

sde = os.path.join(os.path.dirname(__file__), '..', 'pro-project', 'localhost@utrans.sde')

TABLE = os.path.join(sde, table_name)

from pathlib import Path

sde = Path(__file__).parent / '..' / 'pro-project', 'localhost@utrans.sde'

TABLE = str(sde / table_name)

steveoh · 2021-03-16T22:08:00Z

-    with arcpy.da.UpdateCursor(TABLE, ['OID@'], where_clause="FacilityName IN ('0', '1')") as cursor:
-        for _ in cursor:
-            cursor.deleteRow()
+    #arcpy.management.TruncateTable(TABLE)


chore: we need to figure out the reset issue otherwise the subsequent tests will fail

are we on the right track

47ee8c2

steveoh changed the title ~~am i on the right track?~~ add full name calculation Dec 10, 2020

steveoh reviewed Dec 10, 2020

View reviewed changes

Comment thread .vscode/settings.json Outdated

Comment thread src/rules/common.py Outdated

Comment thread src/rules/roads.py Outdated

steveoh marked this pull request as draft December 10, 2020 17:50

gregbunce added 3 commits December 10, 2020 14:14

get branch update from origin

c626ec6

Merge branch 'feat/road-name-calculation' of https://github.com/agrc/…

6aee1eb

…utrans-attribute-rules into feat/road-name-calculation i realign local with remote

remove hardcoded path

3290cb4

gregbunce marked this pull request as ready for review December 14, 2020 15:56

steveoh self-requested a review December 14, 2020 18:02

steveoh self-assigned this Dec 14, 2020

add xml schema doc

e0b5985

steveoh added 12 commits December 24, 2020 15:44

docs: update reference data

b17874c

fix: make rules execute

d43c004

chore: create version information table

ebb54bd

fix: editable is not yes no any longer

82aae2d

refactor: remove for py3

dd489c9

fix: syntax error

8367ebd

fix: return null instead of setting value to true

3ac1701

this might not be the expected behavior

chore: remove readme

a66b50e

fix: add localhost connection

0874837

chore: add proproject

bdfa788

chore: ignore pro project cruft

46e1445

chore: update dictionary

bbb3eb2

steveoh suggested changes Dec 24, 2020

View reviewed changes

steveoh marked this pull request as draft December 24, 2020 21:59

gregbunce added 8 commits December 30, 2020 15:57

chore: update readme

245f9b2

chore: add road xml data

37b315b

chore: make reference data a list

134215a

update sde file name

cdc57c1

update stage and prod sde conn file names

ca6ed6f

fix null to zero expression

9a26889

this is now working in arcgis pro testing

fix null to zero expression

e52be3e

this is now working in arcgis pro testing

fix upper calculations

d8e0f41

and set triggers to update; also rename ar rules to reflect the associated field name

gregbunce added 2 commits March 16, 2021 15:32

update arcpy install to conda

11cac04

add rules testing for fullname

fa4748e

steveoh reviewed Mar 16, 2021

View reviewed changes

steveoh assigned gregbunce and unassigned steveoh May 14, 2024

		sde = os.path.join(os.path.dirname(__file__), '..', 'pro-project', 'localhost@utrans.sde')
		TABLE = os.path.join(sde, table_name)

-sde = os.path.join(os.path.dirname(__file__), '..', 'pro-project', 'localhost@utrans.sde')
-TABLE = os.path.join(sde, table_name)
+from pathlib import Path
+sde = Path(__file__).parent / '..' / 'pro-project', 'localhost@utrans.sde'
+TABLE = str(sde / table_name)

Conversation

gregbunce commented Dec 10, 2020

Uh oh!

steveoh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregbunce commented Dec 10, 2020

Uh oh!

steveoh commented Dec 14, 2020

Uh oh!

gregbunce commented Dec 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregbunce commented Dec 23, 2020

Uh oh!

steveoh commented Dec 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steveoh left a comment

Choose a reason for hiding this comment

Uh oh!

gregbunce commented Dec 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steveoh commented Dec 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregbunce commented Dec 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steveoh commented Dec 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregbunce commented Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steveoh left a comment

Choose a reason for hiding this comment

Uh oh!

steveoh Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

steveoh Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

steveoh Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

steveoh Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gregbunce commented Dec 23, 2020 •

edited

Loading

steveoh commented Dec 24, 2020 •

edited

Loading

gregbunce commented Dec 30, 2020 •

edited

Loading

steveoh commented Dec 30, 2020 •

edited

Loading

gregbunce commented Dec 30, 2020 •

edited

Loading

steveoh commented Dec 30, 2020 •

edited

Loading

gregbunce commented Jan 22, 2021 •

edited

Loading