fix(notices): restore the pinned 1.98.1 standard-library notices - #11
Merged
Merged
Conversation
The v0.13.0 bump regenerated the notice bundles under the default `stable` toolchain (1.98.0) instead of the pinned 1.98.1, rewriting the recorded Rust standard-library provenance — version, source tarball URL and SHA-256 — backwards. The release build runs `notices:check --check-toolchain` against the runner's 1.98.1 and rejected it, failing v0.13.0 at `Build gravityd`. Regenerated under 1.98.1. Only the toolchain provenance block changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerates the three third-party notice bundles and
inventory.jsonunder thepinned Rust toolchain (1.98.1). Only the standard-library provenance block
changes — recorded
rustcversion, source tarball URL and SHA-256.Why
The v0.13.0 version bump (#10) regenerated the notices under the local default
stabletoolchain (1.98.0) rather than the pinned 1.98.1, rewriting therecorded standard-library provenance backwards. The release workflow runs
pnpm notices:check --check-toolchainagainst the runner's 1.98.1, so thev0.13.0 tag failed at
Build gravitydwith "Rust toolchain changed" beforepublishing anything.
Worth noting: the PR-level
fallowjob runsnotices:checkwithout--check-toolchain, so this class of mismatch is invisible until a tag ispushed. That gap is why #10 went green.
How tested
rustup run 1.98.1for generation, thenpnpm notices:check --check-toolchainunder 1.98.1 — passes ("inputs and bundles match the reviewed inventory").
pnpm run verify— typecheck, Rust and TS suites, lint, builds and the 72visual story checks all pass (exit 0).
Unblocks re-tagging v0.13.0; no release was published for that tag.