Skip to content

fix(scripts): split rendered declaration in lint_zsh_template #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(scripts): split rendered declaration in lint_zsh_template #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/lint-shell-templates.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ lint_sh_template() {
# Lint a rendered zsh template with zsh -n (shellcheck does not support zsh).
lint_zsh_template() {
local tmpl="$1"
local rendered="$tmpdir/$(basename "$tmpl" .tmpl)"
# Declare and assign separately so a failed command substitution in the
# assignment is not masked by `local`'s always-zero exit status
# (shellcheck SC2155).
local rendered
rendered="$tmpdir/$(basename "$tmpl" .tmpl)"
echo "=== $tmpl (zsh) ==="
render_template "$tmpl" > "$rendered"
if command -v zsh >/dev/null 2>&1; then
Expand Down