Adding pandas and xlsxwriter to reqs + Fix date in PasswordSpray detection#4
Merged
Conversation
Contributor
Author
|
Vaguely duplicate of #2 , sorry! 😅 |
evilcel3ri
changed the title
ahmedkhlief
approved these changes
Jan 25, 2021
Owner
ahmedkhlief
left a comment
ahmedkhlief
left a comment
There was a problem hiding this comment.
Thanks for adding the requirement
ahmedkhlief
reviewed
Jan 25, 2021
Contributor
Author
|
Ah? hum... I see, checked the code and that make sense. Nonetheless, for some reason it shows the right time for the password spray detection. When ran the previous version, the datetime.now really threw me off as it isn't in the same time frame. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When launching a dry run, I noticed some libraries were missing. This PR adds them in the requirements.txt.
It also adds a fix for the PasswordSpray detection which used to use
datetime.nowinstead of the actual date in the log file.