fix(vllm): prevent Ultra DS-tail copy offset overflow#10552
Open
sungsooha wants to merge 1 commit into
Open
Conversation
Contributor
|
👋 Hi sungsooha! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
443c1e6 to
6a82e45
Compare
Signed-off-by: Sungsoo Ha <sungsooh@nvidia.com> (cherry picked from commit ae942ac)
6a82e45 to
8c5667d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Fix a Nemotron Ultra DS-layout Mamba conv-state tail-copy overflow that can surface as CUDA illegal memory access under GB200 long-context MTP traffic.
The failing path is specific to prefix cache ON +
VLLM_SSM_CONV_STATE_LAYOUT=DS+--mamba-cache-mode align+ MTP. The DS-tail Triton copy kernel can compute source/destination element offsets above signed 32-bit range; this PR keeps that pointer-offset arithmetic intl.int64.Details:
0005-ultra-ds-tail-copy-i64-offsets.patch.ds_conv_tail_copy_kernelso rows/cols and block/stride/offset operands are converted totl.int64before pointer-offset multiplication/addition.NEMOTRON_ULTRA_DS_TAIL_I64_OFFSET_FIXunder the existingmtp_ds_copymarker group.Validation evidence:
dst_over2G_count=37max_dst_elem_offset=2679660544ds_conv_tail_copy_kernelds_tail_count=128dst_over2G_count=48max_dst_elem_offset=2840651774Where should the reviewer start?
container/deps/vllm/patches/v0.22.0/ultra/0005-ultra-ds-tail-copy-i64-offsets.patchcontainer/deps/vllm/validate_nemotron_ultra_runtime.pyRelated Issues
🔗 This PR is linked to an issue:
🚫 This PR is NOT linked to an issue: