feat(routing): unified structured Selected-worker INFO log across all router modes#10554
Open
nnshah1 wants to merge 3 commits into
Open
feat(routing): unified structured Selected-worker INFO log across all router modes#10554nnshah1 wants to merge 3 commits into
nnshah1 wants to merge 3 commits into
Conversation
… router modes Signed-off-by: nnshah1 <neelays@nvidia.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: nnshah1 <neelays@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR enhances observability in router worker selection by converting formatted log messages to structured ChangesRouter Selection Observability
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
…red field Signed-off-by: nnshah1 <neelays@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every router-mode worker selection now emits one consistent, structured,
info-level "Selected worker" log, so routing decisions are visible without flippingDYN_LOG. Previously the modes were inconsistent — RoundRobin/Random/LeastLoaded logged attrace, P2C atdebug, DeviceAwareWeighted and KV atinfobut with ad-hoc fields.Unified schema
Per mode:
trace!→info!with structured fields (LL also logsload).debug!→info!, retaining the candidate detail (candidate_a/b, loads); logs once per selection including the single-candidate path.endpoint/is_cpu.info!messages, added structured fields (router_mode,worker_id,worker_type,dp_rank,logit, block counts).info!at dispatch (router_mode="direct",worker_id; nocandidate_count/loadsince the worker is caller-supplied).Log aggregators can now grep/filter on
router_mode/worker_id/loaduniformly across all modes for imbalance analysis.Test
cargo check/fmt/clippyclean ondynamo-runtime+dynamo-kv-router.🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes