Fix ResourceClaim cleanup on v1beta2 clusters#642
Open
iaroslav-reflection wants to merge 2 commits into
Open
Conversation
unmarshall
reviewed
Jun 2, 2026
Collaborator
There was a problem hiding this comment.
Creation of the ResourceClaim uses v1. Will this not be an issue for k8s version 1.33 where the version was v1beta2?
Collaborator
There was a problem hiding this comment.
Similarly a Get call uses only v1 and does not support v1beta2
Member
|
/ok to test feebecc |
Signed-off-by: Meenakshi Sharma <163925564+nvda-mesharma@users.noreply.github.com>
|
/ok to test 90f52d1 |
1 similar comment
|
/ok to test 90f52d1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource.k8s.io/v1ResourceClaim cleanup pathresource.k8s.io/v1beta2when the API server does not servev1Before / After
resource.k8s.io/v1only.v1first and falls back tov1beta2on Kubernetes no-match errors.v1.v1->v1beta2fallback.v1metadata only.v1beta2, so finalizers can verify cleanup on Kubernetes 1.33 clusters.Validation
go test ./internal/resourceclaim ./internal/controller/podcliqueset/components/resourceclaim ./internal/controller/podclique/components/resourceclaimgo test ./internal/resourceclaim -run 'Test(DeleteResourceClaim|DeleteResourceClaims|ListResourceClaimMetadata)' -count=1 -vContext
Some Kubernetes 1.33 clusters serve DRA ResourceClaims as
resource.k8s.io/v1beta2but notresource.k8s.io/v1. The old cleanup code returned a RESTMapper no-match error in that case, which could leave Grove finalizers stuck even when there were no matching ResourceClaims to delete.